migrate to ESLint flat config, convert to ESM#4737
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
can you make sure ide detection still works? because the eslint extension in vscode sometimes stops working when migrating to eslint v9 here's an example |
|
Thanks for bringing this up! 👍 Usually, in-IDEs detection problems reflects the issues in the lint config definition, or monorepo/workspace setup on users machine. For this PR, I have tested the following editors (also with MD/MDX content, not only for JS/CJS/MJS/TS as seen on screenshots below):
|
|
awesome, it seems as long as the eslint config is exported from the root of the project then it's correctly detected by IDEs, so in the case of nextra i needed to reexport from root it because it's defined in a package |
robhogan
left a comment
robhogan
left a comment
There was a problem hiding this comment.
This is some really nice cleanup and modernisation, thanks!
4 participants
Why
Refactor and migrate to flat config ESLint v9 setup. Convert monorepo to ESM to leverage properly minimal required Node version and simplify linting.
How
Upgrade ESLint to v9, convert setup to flat config, remove redundant stand-alone Prettier checks.
In the process, I have also:
scriptsdirectory, and all monorepo packages resides inpackagesdirectorylint-examplespackages scripts, and formatted./docsfiles using itsync-api-docspackages, it runs correctly, but looks like no files in core repo contain@generate-docsannotation anymoreremark-lint-no-broken-external-links checkplugin for unversioned docs via new script which should be run locallyimage-checkscriptFuture TODOs
@eslint/csscannot parse SCSS files yet), for now we only use stand-alone Prettier to format the filesTest plan
All lint checks and tests across monorepo are working and do not yield any errors. Website apps runs and builds as expected.